Add gradle.properties file to build sql with -Pcrypto.standard=FIPS=140-3 by default#1343
Merged
dbwiddis merged 2 commits intoopensearch-project:mainfrom Mar 27, 2026
Merged
Conversation
…40-3 by default Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
amitgalitz,
dbwiddis,
jackiehanyang,
joshpalis,
junweid62,
ohltyler and
owaiskazi19
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
=========================================
Coverage 77.62% 77.62%
Complexity 1267 1267
=========================================
Files 106 106
Lines 5904 5904
Branches 612 612
=========================================
Hits 4583 4583
Misses 1025 1025
Partials 296 296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Can you update the DEVELOPER_GUIDE with this information? |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Member
Author
Done. |
peterzhuamazon
approved these changes
Mar 27, 2026
66 tasks
dbwiddis
approved these changes
Mar 27, 2026
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
…40-3 by default (#1343) * Add gradle.properties file to build sql with -Pcrypto.standard=FIPS=140-3 by default Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update DEVELOPER_GUIDE Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 48e585c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Mar 27, 2026
…standard=FIPS=140-3 by default (#1344) Add gradle.properties file to build sql with -Pcrypto.standard=FIPS=140-3 by default (#1343) * Add gradle.properties file to build sql with -Pcrypto.standard=FIPS=140-3 by default * Update DEVELOPER_GUIDE --------- (cherry picked from commit 48e585c) Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inspired by opensearch-project/ml-commons#4719, this PR adds a gradle.properties file so that we only need to declare
-Pcrypto.standard=FIPS-140-3in a single place. Now its not necessary to pass the build param in commands like./gradlew assemble -Pcrypto.standard=FIPS-140-3as it passes the arg by default.In order to build without the flag, you would need to override like so:
./gradlew assemble -Pcrypto.standard=any-supportedRefactoring
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.